Skip to content
This repository has been archived by the owner on Mar 21, 2024. It is now read-only.

<tuple> enabled on gcc and clang #17

Merged
merged 23 commits into from
Oct 3, 2020
Merged

<tuple> enabled on gcc and clang #17

merged 23 commits into from
Oct 3, 2020

Conversation

wmaxey
Copy link
Member

@wmaxey wmaxey commented Sep 22, 2020 •
edited
Loading

Builds are clean on nvrtc, win32, and major gcc and clang versions.

MSVC is disabled.

@brycelelbach brycelelbach changed the title WIP: Feature/tuple WIP: <tuple> for non-MSVC compilers Sep 28, 2020
@brycelelbach brycelelbach requested a review from griwes September 28, 2020 17:47
@brycelelbach brycelelbach added this to the 1.3.0 milestone Sep 28, 2020
@brycelelbach
Copy link
Collaborator

@wmaxey let's ship <tuple> for non-MSVC compilers this week in 1.3.0 for the next CUDA toolkit.

@wmaxey
Copy link
Member Author

wmaxey commented Sep 28, 2020

@wmaxey let's ship <tuple> for non-MSVC compilers this week in 1.3.0 for the next CUDA toolkit.

@brycelelbach
Sounds good.

I've noticed that the reference construction issue is present in gcc-7.5 similar to gcc-8.

Tests are exempt on MSVC so it should be good to go there. Should we try to apply a workaround for these compilers?

Re: What we uncovered in August: there might be a few approaches that would satisfy NVCC's default reference construction complaint.

@brycelelbach
Copy link
Collaborator

I've noticed that the reference construction issue is present in gcc-7.5 similar to gcc-8.

Do we have a workaround for that?

@brycelelbach
Copy link
Collaborator

Re: What we uncovered in August: there might be a few approaches that would satisfy NVCC's default reference construction complaint.

Can we implement any of them this week?

@wmaxey
Copy link
Member Author

wmaxey commented Sep 29, 2020 •
edited
Loading

I've committed the changes that work as a WAR for the reference construction in gcc-8 and added a test to demonstrate if the fix is no longer required.

@wmaxey wmaxey force-pushed the feature/tuple branch 3 times, most recently from 0c0566f to bad7149 Compare September 29, 2020 05:39
@wmaxey wmaxey changed the title WIP: <tuple> for non-MSVC compilers <tuple> enabled on gcc and clang Sep 30, 2020
@wmaxey wmaxey marked this pull request as ready for review September 30, 2020 03:28
@wmaxey wmaxey requested a review from brycelelbach September 30, 2020 03:29
@alliepiper alliepiper mentioned this pull request Sep 30, 2020
Closed
@wmaxey
Copy link
Member Author

wmaxey commented Oct 2, 2020

@brycelelbach @griwes This is ready to be merged in. Just need a review to satisfy GH if I'm not mistaken.

griwes
griwes approved these changes Oct 2, 2020
View reviewed changes
Copy link
Collaborator

@griwes griwes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, but don't gate shipping this on them.

@brycelelbach brycelelbach merged commit c8cf57b into NVIDIA:main Oct 3, 2020
@wmaxey wmaxey deleted the feature/tuple branch October 3, 2020 01:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@griwes griwes griwes approved these changes

@brycelelbach brycelelbach Awaiting requested review from brycelelbach

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@wmaxey @brycelelbach @griwes