Memory leaks in XML config generation. #321
Comments
capcah
added a commit
to capcah/nccl
that referenced
this issue
Apr 14, 2020
This patch fixes the memory leak documented in NVIDIA#321, where one of the buffers allocated by realpath(), inside getPciPath() is not freed. The memory management aspect of this function also seemed odd and unecessary, as the realpath() function is documented to only write up to PATH_MAX bytes to the buffer passed to it, meaning we don't need dynamic memory allocation at all. I also changed the function signature of getPciPath to enforce the use of a fixed-size buffer.
capcah
added a commit
to capcah/nccl
that referenced
this issue
Apr 14, 2020
This patch fixes the memory leak documented in NVIDIA#321, where one of the buffers allocated by realpath(), inside getPciPath() is not freed. The memory management aspect of this function also seemed odd and unecessary, as the realpath() function is documented to only write up to PATH_MAX bytes to the buffer passed to it, meaning we don't need dynamic memory allocation at all. I also changed the function signature of getPciPath to enforce the use of a fixed-size buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Running our tests under ASAN, we found a memory leak in xml.cc, where one of the calls for getPciPath does not free the expanded path. I'll soon submit a PR closing this issue.
The text was updated successfully, but these errors were encountered: