Allow Pynvjitlinker Enabled via Config at Runtime #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmarkall
reviewed
Dec 18, 2024
gmarkall
reviewed
Dec 18, 2024
gmarkall
added
4 - Waiting on author
gmarkall
added
4 - Waiting on reviewer
gmarkall
reviewed
Dec 18, 2024
3 tasks
gmarkall
added
5 - Ready to merge
rapids-bot bot
pushed a commit
to rapidsai/cudf
that referenced
this pull request
Jan 9, 2025
Numba-cuda 0.0.18+ merged in a new feature and made the old way of patching linker with pynvjitlink's `patch_numba_linker` no longer usable by downstream libraries. The current state of Numba-cuda requires that downstream libraries to enable pynvjitlink features only via `CUDA_ENABLE_PYNVJITLINK` environment variable. A recent PR NVIDIA/numba-cuda#91 makes it so that the features can be turned on by a config variable at runtime. This PR is an integration test with that PR and changing the way how pynvjitlink is enabled in cuDF. It enables cuDF to use Numba-cuda since 0.2.0+ (which contains the config change). Supercedes #17359 Authors: - Michael Wang (https://github.com/isVoid) - Peter Andreas Entschev (https://github.com/pentschev) - Bradley Dice (https://github.com/bdice) Approvers: - Peter Andreas Entschev (https://github.com/pentschev) - Bradley Dice (https://github.com/bdice) - Vyas Ramasubramani (https://github.com/vyasr) URL: #17628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.