Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEA] Support simple DECIMAL aggregates #1316

Closed
revans2 opened this issue Dec 8, 2020 · 0 comments
Closed

[FEA] Support simple DECIMAL aggregates #1316

revans2 opened this issue Dec 8, 2020 · 0 comments
Assignees
@revans2
Labels
feature request New feature or request

Comments

@revans2
Copy link
Collaborator

revans2 commented Dec 8, 2020 •
edited
Loading

The operators UnscaledValue and MakeDecimal open up the possibility of doing a lot of aggregations on 64-bit and smaller decimal values without any extra support from cudf.

The main thing we need are JNI changes in cudf to either expose logical_cast with a copy. That is because UnscaledValue is doing a logical cast on a DECIMAL_64 to an INT_64, and MakeDecimal is doing the opposite.

We should also allow decimal in HashAggregateExec and write some tests that verify that this works correctly.
@revans2 revans2 added feature request New feature or request ? - Needs Triage Need team to review and classify labels Dec 8, 2020
@sameerz sameerz removed the ? - Needs Triage Need team to review and classify label Dec 8, 2020
@revans2 revans2 changed the title [FEA] Support expressions UnscaledValue and MakeDecimal [FEA] Support simple DECIMAL aggregates Dec 8, 2020
@revans2 revans2 mentioned this issue Dec 8, 2020
Closed
27 tasks
@revans2 revans2 self-assigned this Dec 9, 2020
This was referenced Dec 10, 2020
Closed
Merged
@revans2 revans2 closed this as completed Dec 14, 2020
tgravescs pushed a commit to tgravescs/spark-rapids that referenced this issue Nov 30, 2023
@nvauto
Update submodule cudf to 8370cbe7f21872ea7106a7a8577a1b1a124608ff (NV…
2cb1496 
…IDIA#1316)

Signed-off-by: spark-rapids automation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@revans2 revans2

Labels
feature request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@revans2 @sameerz