This repository has been archived by the owner on Mar 21, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 756
Update for cub::FutureValue
PR (NVIDIA/cub#305)
#1519
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can one of the admins verify this patch? |
e446214
to
1ce950e
Compare
1ce950e
to
d21ee55
Compare
My last push just updated the CUB submodule so gpuCI can pick it up. DVS CL: 30512893 run tests |
e1d0681
to
600e57e
Compare
@allisonvacanti The compilation failures should be fixed now. |
DVS CL: 30535270 run tests |
cub::FutureValue
PR (NVIDIA/cub#305)
Seems unrelated |
@zasdfgbnm Yeah, that's a known compiler bug in gcc 10, it can be ignored. Internal testing on DVS also looks clean, so this is ready to go in -- thanks for advocating for this and doing the work, I really like how this feature turned out! 😀 I'll get this merged in a moment. |
alliepiper
approved these changes
Oct 15, 2021
600e57e
to
56aa510
Compare
56aa510
to
1daa53e
Compare
Last couple of pushes just updated the CUB submodule. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
helps: pytorch
Helps or needed by PyTorch.
P1: should have
Necessary, but not critical.
testing: gpuCI passed
Passed gpuCI testing.
testing: internal ci passed
Passed internal NVIDIA CI (DVS).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review NVIDIA/cub#305