Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to CMake #128

Merged
merged 2 commits into from
Apr 11, 2023
Merged

Switch to CMake #128

merged 2 commits into from
Apr 11, 2023

Conversation

zachcran
Copy link
Contributor

PR Type

  • Breaking change
  • Feature
  • Patch

Brief Description

Not In Scope

PR Checklist

TODOs

  • Task 1
  • Task 2

@zachcran
Copy link
Contributor Author

@ryanmrichard It looks like something is hanging when running the tests here. Any ideas?

@zachcran
Copy link
Contributor Author

The build seems to work on my local system, too, but the tests fail with MADNESS: fatal error: caught an STL exception.

@ryanmrichard
Copy link
Member

It looks like deadlock. Why it's happening now? No idea.

@zachcran
Copy link
Contributor Author

@ryanmrichard Since all of the other repositories have passed their tests and been merged, I believe it is safe to say we can merge this one. The test issue is still present, but I think it is out of the scope of this PR. The repo was successfully built and the tests were started.

@ryanmrichard ryanmrichard merged commit 3073b8e into master Apr 11, 2023
@ryanmrichard ryanmrichard deleted the switch_to_cmaize branch April 11, 2023 02:14
@ryanmrichard
Copy link
Member

🚀 [bumpr] Bumped! New version:v0.0.4 Changes:v0.0.3...v0.0.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants