removed debugger logging, updated error copy

NYCPlanning · Jan 23, 2025 · ce089cb · ce089cb
1 parent f234efe
commit ce089cb
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 38 deletions.
diff --git a/client/app/components/projects/new.hbs b/client/app/components/projects/new.hbs
@@ -51,11 +51,7 @@
         disabled={{or (not saveableProjectsNewForm.isSubmittable) this.submissionError this.isSubmitting}}
         @continueButtonTitle="Continue Editing" data-test-confirm-submit-button={{true}}>
         <h6>Confirm New Project Submission</h6>
-        {{#if this.submissionError}}
-        <div class="grid-x medium-padding-top medium-padding-bottom">
-          <p class="header-large medium-marin-top small-margin-bottom">Error while creating project. Lorem Ipsum.....</p>
-        </div>
-        {{else}}
+
           <p class="header-large medium-margin-top small-margin-bottom">
             Are you sure?
           </p>
@@ -69,7 +65,11 @@
             Please refresh your browser if you do not immediately see your project under the Other Projects section of the home
             page.
           </p>
-        {{/if}}
+          {{#if this.submissionError}}
+            <div class="grid-x medium-padding-top medium-padding-bottom">
+              <p class="header-large medium-marin-top small-margin-bottom">An error may have occurred while creating project</p>
+            </div>
+          {{/if}}
       </saveableProjectsNewForm.ConfirmationModal>
     </div>
   </div>

diff --git a/client/app/components/projects/new.js b/client/app/components/projects/new.js
@@ -18,8 +18,6 @@ export default class ProjectsNewFormComponent extends Component {
   @tracked
   isSubmitting = false;
 
-  requestCounter = 0;
-
   @service
   router;
 
@@ -39,9 +37,6 @@ export default class ProjectsNewFormComponent extends Component {
     this.submissionError = false;
     if (this.isSubmitting) return;
     this.isSubmitting = true;
-    const requestStartTime = Date.now();
-    this.requestCounter++;
-    console.log(`LOGGER: [Total Requests Made in the client controller] ${this.requestCounter}`);
 
     const primaryContactInput = {
       first: this.args.package.primaryContactFirstName,
@@ -131,9 +126,6 @@ export default class ProjectsNewFormComponent extends Component {
         }),
       });
       const { data: project } = await response.json();
-      const requestEndTime = Date.now();
-      console.debug(`LOGGER: POST request in the client controller to took ${requestEndTime - requestStartTime} ms`);
-      console.debug('response in client controller: ', response, 'response status: ', response.status);
 
       const artifactsId = project.attributes['dcp-artifactsid'];
       if (artifactsId === undefined) {

diff --git a/client/app/routes/projects/new.js b/client/app/routes/projects/new.js
@@ -13,6 +13,10 @@ export default class ProjectsNewRoute extends Route.extend(
   async model() {
     const projectsNewForm = this.store.createRecord('project-new');
 
+    /*
+      We need to create a pseudo project id in order to enable document attachments within the new projects form.
+      The actual project id will be assigned after the form is submitted to the CRM
+     */
     projectsNewForm.id = `new${self.crypto.randomUUID()}`;
     projectsNewForm.createFileQueue();
 

diff --git a/server/src/crm/crm.service.ts b/server/src/crm/crm.service.ts
@@ -19,7 +19,6 @@ export class CrmService {
   crmUrlPath = '';
   crmHost = '';
   host = '';
-  requestCounter = 0;
 
   constructor(private readonly config: ConfigService) {
     ADAL.ADAL_CONFIG = {
@@ -64,19 +63,12 @@ export class CrmService {
 
   async create(query, data, headers = {}) {
     try {
-      console.debug(
-        "LOGGER CRM create query", query,
-        "LOGGER CRM create data", data,
-        "LOGGER CRM create headers", headers,
-      );
-      const requestStartTime = Date.now();
       const response = this._create(query, data, headers);
-      const requestEndTime = Date.now();
-      console.debug(`LOGGER: LOGGER CRM create request took ${requestEndTime - requestStartTime} ms`);
+
       return response;
 
     } catch (e) {
-      console.debug(`LOGGER error in CRM create: ${e}`);
+      console.debug(`error in CRM create: ${e}`);
     }
   }
 

diff --git a/server/src/projects/projects.controller.ts b/server/src/projects/projects.controller.ts
@@ -85,7 +85,6 @@ import { AuthorizeGuard } from 'src/authorize.guard';
 @Controller('projects')
 export class ProjectsController {
   CRM_IMPOSTER_ID = '';
-  requestCounter = 0;
 
   constructor(
     private readonly projectsService: ProjectsService,
@@ -137,7 +136,6 @@ export class ProjectsController {
   @Post('/')
   @Relationships('self')
   async createProject(@Body() body) {
-    const requestStartTime = Date.now();
     const allowedAttrs = pick(body, PROJECT_ATTRS) as {
       dcp_projectname: string;
       dcp_borough: string;
@@ -155,10 +153,6 @@ export class ProjectsController {
         HttpStatus.NOT_FOUND,
       );
     }
-    const requestEndTime = Date.now();
-    this.requestCounter++;
-    console.log(`LOGGER: [Total Requests Made in the controller] ${this.requestCounter}`)
-    console.debug(`LOGGER: POST request in the controller to took ${requestEndTime - requestStartTime} ms`);
 
     return await this.projectsService.create(allowedAttrs);
   }

diff --git a/server/src/projects/projects.service.ts b/server/src/projects/projects.service.ts
@@ -10,7 +10,6 @@ const APPLICANT_ACTIVE_STATUS_CODE = 1;
 const PROJECT_ACTIVE_STATE_CODE = 0;
 const PROJECT_VISIBILITY_APPLICANT_ONLY = 717170002;
 const PROJECT_VISIBILITY_GENERAL_PUBLIC = 717170003;
-let requestCounter = 0;
 
 const PACKAGE_VISIBILITY = {
   APPLICANT_ONLY: 717170002,
@@ -113,8 +112,6 @@ export class ProjectsService {
     _dcp_applicantadministrator_customer_value: string;
   }) {
     try {
-      const requestStartTime = Date.now();
-
       const data = {
         dcp_projectname: attributes.dcp_projectname,
         dcp_borough: attributes.dcp_borough,
@@ -135,16 +132,12 @@ export class ProjectsService {
       const dcpArtifactsId = artifact['dcp_artifactsid'];
       if (dcpArtifactsId === undefined) throw new Error('Failed to create artifact for project');
 
-      const requestEndTime = Date.now();
-      console.debug(`LOGGER: POST (service)  request in the service to took ${requestEndTime - requestStartTime} ms`);
-      requestCounter++;
-      console.log(`LOGGER: [Total Requests Made in the service] ${requestCounter}`);
       return {
         dcp_projectid: dcpProjectId,
         dcp_artifactsid: dcpArtifactsId,
       };
     } catch (e) {
-      console.error('(service) error creating project', e);
+      console.error('error creating project', e);
       throw new HttpException(
         'Unable to create project',
         HttpStatus.INTERNAL_SERVER_ERROR,