Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract getProfileData into a separate place #69

Closed
allthesignals opened this issue Apr 17, 2019 · 1 comment
Closed

Extract getProfileData into a separate place #69

allthesignals opened this issue Apr 17, 2019 · 1 comment

Comments

@allthesignals
Copy link
Collaborator

naming is not low hanging fruit if you ask me! I definitely think profile qp should become profileName

also, happy to extract the getProfileData into a separate place. I extracted it b/c i was thinking it could be repurposed in a route that does not require a selection ID but rather accepts a list of geoids -- wouldn't be used in the front end, but could be useful to people like that grad student that emailed & wanted to scrape a bunch of profile data; they could programatically hit that route, esp if we allow 'compare' to be optional. but I agree that I don't necessarily love the idea of this living in a util. Let's think about where else this could go ?

Originally posted by @julialucyhogan in #68

@allthesignals
Copy link
Collaborator Author

Issue moved to NYCPlanning/labs-factfinder #752 via ZenHub

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant