You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
naming is not low hanging fruit if you ask me! I definitely think profile qp should become profileName
also, happy to extract the getProfileData into a separate place. I extracted it b/c i was thinking it could be repurposed in a route that does not require a selection ID but rather accepts a list of geoids -- wouldn't be used in the front end, but could be useful to people like that grad student that emailed & wanted to scrape a bunch of profile data; they could programatically hit that route, esp if we allow 'compare' to be optional. but I agree that I don't necessarily love the idea of this living in a util. Let's think about where else this could go ?
@allthesignals commented on Wed Apr 17 2019
naming is not low hanging fruit if you ask me! I definitely think
profile
qp should becomeprofileName
also, happy to extract the
getProfileData
into a separate place. I extracted it b/c i was thinking it could be repurposed in a route that does not require a selection ID but rather accepts a list of geoids -- wouldn't be used in the front end, but could be useful to people like that grad student that emailed & wanted to scrape a bunch of profile data; they could programatically hit that route, esp if we allow 'compare' to be optional. but I agree that I don't necessarily love the idea of this living in autil
. Let's think about where else this could go ?Originally posted by @julialucyhogan in NYCPlanning/labs-factfinder-api#68
The text was updated successfully, but these errors were encountered: