Fix patron expiration test

[tdilauro]

Description

This branch fixes a couple of tests that used the wrong time zone for patron expiration date/time values.

Motivation and Context

Depending on local time zone and time of day when run, the affected tests might or might not fail. The tests in question were using UTC time for patron expiration, but the PatronUtility.authorization_is_active uses server local time.

Fixes #741

How Has This Been Tested?

Successfully ran the remediated tests late night EDT, when they were originally failing, and mid-morning EDT when they previously were NOT failing.

TESTING=true PYTHONWARNINGS=ignore nosetests -w tests \
  test_patron_utility.py:TestPatronUtility.test_has_borrowing_privileges \
  test_patron_utility.py:TestPatronUtility.test_needs_external_sync

Checklist:

• I have updated the documentation accordingly.
• All new and existing tests passed.

[tdilauro]

Any idea why sphinx is erroring in Travis? It's working fine in my local environment.

[leonardr]

There was a release of the rsa package 18 hours ago, which silently dropped Python 2 support. This is the same thing that happened recently to NLTK. You can fix it by pinning rsa to "<4.1" in requirements.txt.

[leonardr]

Here's the bug on the rsa side.

[leonardr]

The code itself looks good; you just drew the requirements.txt short straw.

[tdilauro]

Thanks, @leonardr. All set.

[sybrenstuvel]

I fixed it in the Python-RSA package so that package managers now know which version they can use. Python-RSA 4.3 is now the last one to support Python 2.7, version 4.4 explicitly requires Python 3.5+.

Hope this is now resolved for you, if there are still issues let me know.

[leonardr]

Thanks, Sybren, we appreciate it.