Skip to content

Commit

Permalink
Merge pull request #39 from NYPL/SCC-4482-workflow-updates
Browse files Browse the repository at this point in the history
Updates for PR #37
  • Loading branch information
yossariano authored Feb 7, 2025
2 parents eac5098 + 45e8089 commit 78d1cb8
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
5 changes: 5 additions & 0 deletions .github/workflows/deploy-qa.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,11 @@ jobs:
role-to-assume: arn:aws:iam::946183545209:role/GithubActionsDeployerRole
aws-region: us-east-1
- uses: actions/checkout@v3
- name: Set up Ruby
uses: ruby/setup-ruby@v1
with:
ruby-version: 3.3
bundler-cache: true
- name: Package app
run: bash provisioning/package.sh
- uses: hashicorp/setup-terraform@v2
Expand Down
2 changes: 1 addition & 1 deletion lib/item.rb
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def is_research?(data=nil)
item_type_check = item_type_is_research?
location_check = location_is_only_research?

raise DataError.new("Result could not be determined") if item_type_check.nil? && location_check.nil?
raise DataError.new("is_research result for #{nypl_source} #{id} could not be determined") if item_type_check.nil? && location_check.nil?

result = item_type_check || location_check
end
Expand Down

0 comments on commit 78d1cb8

Please sign in to comment.