-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backup #119
Backup #119
Conversation
Just tested this. Seemed to work well, however, on restore, the birds.db has the wrong permissions. Should be 666 but restored as 644. Found this by trying to delete a recording after restoring. Gave a read only error. |
Ok. Adding a -p to the restore tar command seems to fix it! Although, with lack of sleep, I may not be able to be trusted! |
Looks a really nice feature, thanks ! |
scripts/backup_data.sh
Outdated
restore() { | ||
log "Starting restore" | ||
for obj in "${objects[@]}";do | ||
tar --extract - p -f "$ARCHIVE" -C "$(dirname "$obj")" "$(basename "$obj")" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a space between - and p that shouldn't be there...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doh!
e1dc766
to
62ed4a6
Compare
Nice feature thanks ! |
bzipping would provide smaller backup files.
|
I did consider compression briefly, however mp3 and png files, the biggest part of an actual backup by a large margin, are not compressible. Even the birds.db database, the only notable file that would be worth compressing, is dwarfed by these. |
No description provided.