Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI : Convert checkbox to toggleswitch #209

Merged
merged 9 commits into from
Oct 12, 2024

Conversation

alexbelgium
Copy link

@alexbelgium alexbelgium commented Oct 2, 2024

Not very useful but prettier :-)
Tested on windows and ios

Before :
image

After :
image image
image image

@bdeschut
Copy link

bdeschut commented Oct 2, 2024

Personal opinion: for me it wouldn't be clear if the toggle is on or off, given that the color or the text doesn't change (I refer to the two screenshots you provided). Perhaps add some color?
image

@alexbelgium
Copy link
Author

Thanks for the feedback, indeed makes total sense ! As I haven't modified the main css files to make it simpler, it would need to cover both light and dark themes. Would such a layout be ok :

image
image

@bdeschut
Copy link

bdeschut commented Oct 2, 2024

It is definitely an improvement. Not sure if difficult, but for the dark theme (and the light theme as well), this might also be an option:
image

@alexbelgium
Copy link
Author

alexbelgium commented Oct 2, 2024

Thanks for the suggestions. I'm not a fan of text on small elements like that - it would in my opinion lead to clutter especially on smaller screens. However I do understand that the difference of light vs grey shades could be not super explicit.

Here is an update :

  • transparent background when inactive (good for all themes)
  • complex dark gray when active (good for all themes) plus small ON
image image image image

Alternative : checkmarks
image

@alexbelgium
Copy link
Author

What is preferrable : "check" or "ON"

@bdeschut
Copy link

bdeschut commented Oct 3, 2024

Both are clear for me, I slightly prefer the check sign more but both are excellent options

@alexbelgium
Copy link
Author

Thanks for your feedbacks and proposals

@Nachtzuster
Copy link
Owner

Not very useful but prettier :-) Tested on windows and ios

quite 😄

@Nachtzuster Nachtzuster merged commit 305e181 into Nachtzuster:main Oct 12, 2024
@alexbelgium alexbelgium deleted the switch_toggle_purge branch October 12, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants