Update FreeSMS.py #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Finalisation du portage en python 3, ajout de la compatibilité avec un environnement windows. Ajout de messages d'aides adaptés à la plateforme sur laquelle le script tourne. Fonctionnement OK en python 3.9.2 dans windows. Fonctionnement OK en python 3.8.5 dans WSL Ubuntu 20.04
|
Merci @DarkCoocky, je vais regarder ! |
Naereen
requested changes
Apr 5, 2021
| variable = variable[:-1] | ||
| return variable | ||
| if Platform == "win32": | ||
| with open("C:\\Users\\"+Uname+"\\.smsapifreemobile_" + name + number + ".b64") as f: |
There was a problem hiding this comment.
Il faut factoriser ces deux morceaux, et écrire une fonction qui va récupérer le dit fichier, plutôt qu'écrire deux fois le test avec Platform == "win32".
There was a problem hiding this comment.
Créer une fonction du type "OpenWinSpecialFile" et "TestWinSpecialFile" ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalisation du portage en python 3, ajout de la compatibilité avec un environnement windows. Ajout de messages d'aides adaptés à la plateforme sur laquelle le script tourne.
Fonctionnement OK en python 3.9.2 dans windows.
Fonctionnement OK en python 3.8.5 dans WSL Ubuntu 20.04