#142 - stop() method is never called in cached controllers - fixed

NaluKit · Sep 11, 2020 · 1b7766c · 1b7766c
1 parent c2ed916
commit 1b7766c
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 6 deletions.
diff --git a/nalu/src/main/java/com/github/nalukit/nalu/client/internal/application/CompositeFactory.java b/nalu/src/main/java/com/github/nalukit/nalu/client/internal/application/CompositeFactory.java
@@ -109,7 +109,7 @@ private String classFormatter(String className) {
    * Adds the controller to the store of cached controllers.
    * Call this method from inside the controller you like to cache.
    * <p>
-   * This method will not call the <code>start</code>- or <code>activate</code>-method
+   * This method will not call the <code>start</code>- and <code>activate</code>-method
    * of the controller.
    *
    * @param controller the controller to store
@@ -128,7 +128,7 @@ private String classFormatter(String className) {
    * Call this method from inside the controller you like to remove from the cache.
    * In case the controller is not cached, the method does nothing
    * <p>
-   * This method will not call the <code>deactivate</code>- or <code>stop</code>-method
+   * This method will not call the <code>deactivate</code>- and <code>stop</code>-method
    * of the controller.
    *
    * @param controller the controller to remove from the store
@@ -150,7 +150,8 @@ private String classFormatter(String className) {
    * <code>deactivate</code>- and <code>stop</code>-method.
    * <p>
    * DO NOT CALL THIS METHOD INSIDE A CACHED CONTROLLER!
-   * If so, call <code>removeFromCache(this)</code> first!
+   * If you are inside a cached controller, call
+   * <code>removeFromCache(this)</code> first!
    */
   public void clearControllerCache() {
     this.compositeControllerStore.values()

diff --git a/.../src/main/java/com/github/nalukit/nalu/client/internal/application/ControllerFactory.java b/.../src/main/java/com/github/nalukit/nalu/client/internal/application/ControllerFactory.java
@@ -101,7 +101,7 @@ private String classFormatter(String className) {
    * Adds the controller to the store of cached controllers.
    * Call this method from inside the controller you like to cache.
    * <p>
-   * This method will not call the <code>start</code>- or <code>activate</code>-method of the controller.
+   * This method will not call the <code>start</code>- and <code>activate</code>-method of the controller.
    *
    * @param controller the controller to store
    * @param <C>        type of controller
@@ -118,7 +118,7 @@ private String classFormatter(String className) {
    * Call this method from inside the controller you like to remove from the cache.
    * In case the controller is not cached, the method does nothing
    * <p>
-   * This method will not call the <code>deactivate</code>- or <code>stop</code>-method
+   * This method will not call the <code>deactivate</code>- and <code>stop</code>-method
    * of the controller.
    *
    * @param controller the controller to remove from the store
@@ -142,7 +142,8 @@ private String classFormatter(String className) {
    * <code>stop</code>-method of the controller.
    * <p>
    * DO NOT CALL THIS METHOD INSIDE A CACHED CONTROLLER!
-   * If so, call <code>removeFromCache(this)</code> first!
+   * If you are inside a cached controller, call
+   * <code>removeFromCache(this)</code> first!
    */
   public void clearControllerCache() {
     this.controllerStore.values()