Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused generated code is causing compiler warnings #84

Closed
eguardiola opened this issue Sep 5, 2019 · 1 comment
Closed

Unused generated code is causing compiler warnings #84

eguardiola opened this issue Sep 5, 2019 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@eguardiola
Copy link

eguardiola commented Sep 5, 2019

The problem is present on the generated code for the method setParameter for an ControllerCreator:

@Override
  public void setParameter(Object object, String... parms) throws RoutingInterceptionException {
    PersonnelController controller = (PersonnelController) object;
    StringBuilder sb01 = new StringBuilder();
  }

The controller and sb01 will not be used so don't need to be generated. This will cause the java compiler not emit a warning.

@FrankHossfeld FrankHossfeld self-assigned this Sep 5, 2019
@FrankHossfeld FrankHossfeld added the enhancement New feature or request label Sep 5, 2019
@FrankHossfeld FrankHossfeld added this to the 2.0.0 milestone Sep 5, 2019
@FrankHossfeld
Copy link
Collaborator

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants