Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorPopUp-Feature #86

Closed
FrankHossfeld opened this issue Sep 13, 2019 · 1 comment
Closed

ErrorPopUp-Feature #86

FrankHossfeld opened this issue Sep 13, 2019 · 1 comment
Assignees
@FrankHossfeld
Labels
enhancement New feature or request
Milestone
2.0.0

Comments

@FrankHossfeld
Copy link
Collaborator

FrankHossfeld commented Sep 13, 2019 •
edited
Loading

In case Nalu uses the error event feature, implement a feature, that firing the NaluErrorEvent will trigger a popup controller.

Therefore add a new attribute to the @Application-annotation, f.e.: errorPopUp. Implementing the popup should be similar as implementing a PopUpController, except that it has only the values of the event.

Validate, that the errorPopUp-attribute can only be used in case the error route attribute is not used!

This issue is related to the new error feature. (see #61)
@FrankHossfeld FrankHossfeld added the enhancement New feature or request label Sep 13, 2019
@FrankHossfeld FrankHossfeld added this to the 2.0.0 milestone Sep 13, 2019
@FrankHossfeld FrankHossfeld self-assigned this Sep 13, 2019
FrankHossfeld pushed a commit that referenced this issue Sep 15, 2019
#86 - ErrorPopUp-Feature - first implementation
849347b
FrankHossfeld pushed a commit that referenced this issue Sep 16, 2019
#61 - improve error handling
b3bf691 
#86 - ErrorPopUp-Feature
#87 - Remove errorRoute implementation
FrankHossfeld pushed a commit that referenced this issue Sep 16, 2019
#61 - improve error handling
8b9f66b 
#86 - ErrorPopUp-Feature
#87 - Remove errorRoute implementation
@FrankHossfeld
Copy link
Collaborator Author

Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@FrankHossfeld FrankHossfeld

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.0.0
Development

No branches or pull requests
1 participant
@FrankHossfeld