feat(conditions): Simplify conditions #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yyvess
force-pushed
the
feat/conditions
branch
6 times, most recently
from
afd1821 to
ebc3687
Compare
|
This is looking really good @yyvess, appreciate you taking the time to dig in. I'll have a proper look at this tomorrow but agree about simplifying things where possible. |
yyvess
force-pushed
the
feat/conditions
branch
from
ebc3687 to
a7f1587
Compare
|
@Nalum Take your time to review it. Refactoring it help me to learn Cue ;-) I remove around 250 lines of configuration, I test it with default value and some others, result still same. |
yyvess
force-pushed
the
feat/conditions
branch
4 times, most recently
from
ca96f47 to
228ba43
Compare
yyvess
force-pushed
the
feat/conditions
branch
from
228ba43 to
34c24ba
Compare
|
Thank you @yyvess for this awesome PR! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I simplify code by removing
if #component.ServiceAccount & PodDisruptionBudget are now generic.
About Role & RoleBinding, for me it's preferable to define types as to use conditions.
About deployment, I thinks we can continue to simplify it by moving common spec field to #Deployment
What do you thinks ?