Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gorgias): implement gorgias user provisioning using only the necessary User fields and add corresponding tests: #199

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

viictoo
Copy link
Contributor

@viictoo viictoo commented Jan 16, 2025

Describe your changes

Add gorgias user provisioning

Issue ticket number and link

EXT-313

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set
  • I followed the best practices and guidelines from the Writing Integration Scripts doc

…essary User fields and add corresponding tests:

Actions:
- Create user
- Delete user with id
Syncs
- List Users
Copy link

linear bot commented Jan 16, 2025

GorgiasCreateUser:
__extends: CreateUser
role: admin | agent | basic-agent | lite-agent | observer-agent
GorgiasUser:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's just make this User instead of GorgiasUser. This should change in the sync and the actions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used a GorgiasUser type instead of User because User is already being used in a different synchronization with a different type.

    User:
        id: number
        firstname: string
        lastname: string
        meta: object | null
    ```

Copy link
Member

@khaliqgant khaliqgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User instead of GorgiasUser

@viictoo viictoo requested a review from khaliqgant January 27, 2025 14:23
@khaliqgant khaliqgant enabled auto-merge (squash) January 29, 2025 13:29
@khaliqgant khaliqgant merged commit bbb59c9 into main Jan 29, 2025
5 checks passed
@khaliqgant khaliqgant deleted the victor-langat/EXT-313/gorgias-user-provisioning branch January 29, 2025 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants