Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zapier-scim): ext 290/zapier user provisioning #200

Closed
wants to merge 4 commits into from

Conversation

viictoo
Copy link
Contributor

@viictoo viictoo commented Jan 17, 2025

Describe your changes

  • This PR adds support for user provisioning with the Zapier SCIM provider, including user creation, disabling, and synchronization actions

Issue ticket number and link

EXT-290

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is: API is limited to enterprise accounts
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set
  • I followed the best practices and guidelines from the Writing Integration Scripts doc

Copy link

linear bot commented Jan 17, 2025

@viictoo viictoo changed the title Victor/ext 290/zapier user provisioning feat(zapier-scim): ext 290/zapier user provisioning Jan 17, 2025
@viictoo viictoo requested a review from khaliqgant January 17, 2025 10:43
Copy link
Member

@khaliqgant khaliqgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should just be zapier and not zapier-scim and use the

    baseUrlOverride: "https://zapier.com/scim/v2",

since the API setup is the same. The description for the actions and syncs should mention that this is enterprise only as well.

@viictoo viictoo requested a review from khaliqgant January 27, 2025 14:15
@khaliqgant
Copy link
Member

Since this is actually SCIM it is not all that useful as a public template so closing.

@khaliqgant khaliqgant closed this Jan 29, 2025
@khaliqgant khaliqgant deleted the victor/EXT-290/zapier-user-provisioning branch January 29, 2025 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants