Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(brightcrowd): add sync for books and pages #214

Merged
merged 8 commits into from
Feb 13, 2025
Merged

feat(brightcrowd): add sync for books and pages #214

merged 8 commits into from
Feb 13, 2025

Conversation

viictoo
Copy link
Contributor

@viictoo viictoo commented Feb 11, 2025 •
edited
Loading

Describe your changes

Implement books and pages syncs for Brightcrowd

Issue ticket number and link

EXT-493

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set
  • I followed the best practices and guidelines from the Writing Integration Scripts doc

@linear Linear
Copy link

linear bot commented Feb 11, 2025

EXT-493 Brightcrowd syncs

@viictoo viictoo requested a review from khaliqgant February 11, 2025 08:10
@viictoo viictoo marked this pull request as ready for review February 12, 2025 19:38
khaliqgant
khaliqgant reviewed Feb 13, 2025
View reviewed changes
integrations/brightcrowd/nango.yaml Outdated
path: /books
group: Books
scopes: bcb.partner/book.read
booksById:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by convention established by this repo let's make words - separated.

books-by-id

Same for the others

khaliqgant
khaliqgant reviewed Feb 13, 2025
View reviewed changes
integrations/brightcrowd/nango.yaml Outdated
sync_type: full
endpoint:
method: GET
path: /bookAnalytics
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

book-analytics

khaliqgant
khaliqgant requested changes Feb 13, 2025
View reviewed changes
Copy link
Member

@khaliqgant khaliqgant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

naming tweaks requested inline

@viictoo
Copy link
Contributor Author

viictoo commented Feb 13, 2025

naming tweaks requested inline

Updated All to kebab case✅

@viictoo viictoo requested a review from khaliqgant February 13, 2025 14:11
@khaliqgant khaliqgant merged commit 430b033 into main Feb 13, 2025
5 checks passed
@khaliqgant khaliqgant deleted the victor-langat/EXT-493/brightcrowd-syncs branch February 13, 2025 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaliqgant khaliqgant khaliqgant approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viictoo @khaliqgant