Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hubspot-groundwork): add deals and fetch properties to make it easier to work with #32

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

khaliqgant
Copy link
Member

@khaliqgant khaliqgant commented Oct 2, 2024

Describe your changes

Add fetch-properties action and create-deal action to make it easier to work with deals and other create actions in hubspot. The create deal is pretty light weight in that it passes through the data.

Issue ticket number and link

Checklist before requesting a review (skip if just adding/editing APIs & templates)

  • I added tests, otherwise the reason is:
  • External API requests have retries
  • Pagination is used where appropriate
  • The built in nango.paginate call is used instead of a while (true) loop
  • Third party requests are NOT parallelized (this can cause issues with rate limits)
  • If a sync requires metadata the nango.yaml has auto_start: false
  • If the sync is a full sync then track_deletes: true is set

@khaliqgant khaliqgant requested a review from TBonnin October 2, 2024 20:55
}

const config: ProxyConfiguration = {
// https://developers.hubspot.com/docs/api/crm/deals
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops

@khaliqgant khaliqgant merged commit e832464 into main Oct 3, 2024
5 checks passed
@khaliqgant khaliqgant deleted the hubspot-deals branch October 3, 2024 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants