add ability to support free entry of environment variables for nango-server #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses Allow Arbitrary Environment Variables to be set for nango-server. I've attached a screenshot of a basicauth login below:
Note that there are a number of ways to support environment variables within helm charts - two options which I tested/considered are below:
env
value that renders valid YAML. This is rendered utilizing the following:name
andvalue
orvalueFrom
fields which (I thought) offered a greater deal of validation (see "A Note on Iterative Configuration" below).A Note on Iterative Configuration
I was open to utilizing this as it was/is common within the kubernetes/helm community and a popular suggestion on AI sites. What I discovered was this was worse than simply accepting "free entry" as it modified the YAML but did not reject it - an example is below:
When given:
Would render: