fix: use DD_SITE env var instead of hardcoded value #2888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khaliqgant
approved these changes
Oct 24, 2024
bodinsamuel
approved these changes
Oct 24, 2024
| const configuration = client.createConfiguration(); | ||
| configuration.setServerVariables({ | ||
| site: 'us3.datadoghq.com' | ||
| site: process.env['DD_SITE'] |
There was a problem hiding this comment.
I'm not sure we enforce this value, I would just make sure it works or has a default value
There was a problem hiding this comment.
what do you mean by enforce?
btw it is an already existing env var that we are already using in other part of the codebase
There was a problem hiding this comment.
I meant be sure it's there but I forgot there was the if above 🤦🏻
TBonnin
force-pushed
the
tbonnin/nan-1957/dd-site
branch
from
c0fd48b to
32b488c
Compare
TBonnin
force-pushed
the
tbonnin/nan-1957/dd-site
branch
from
32b488c to
45f0ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Using the DD_SITE env var in telemetry.ts instead of hardcoded value.
Issue ticket number and link
https://linear.app/nango/issue/NAN-1957/solve-datadog-issues
Checklist before requesting a review (skip if just adding/editing APIs & templates)