Update length scale measurement scripts to use new imageruler #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oskooi
reviewed
Apr 2, 2024
| python -m pip install --upgrade pip | ||
| pip install numpy | ||
| pip install imageruler | ||
| pip install ceviche-challenges |
There was a problem hiding this comment.
Yes, these are dependencies for the length scale scripts. The alternative would be to specify dependencies in a separate file (e.g. with a pyproject.toml), but since this repo is more of a collection of scripts I went for this approach.
There was a problem hiding this comment.
Why is ceviche-challenges a dependency?
There was a problem hiding this comment.
It’s a dependency in the script for the mode converter.
There was a problem hiding this comment.
(The mode converter script measures length scale and also evaluates the performance of the design.)
stevengj
reviewed
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates all the length scale measurement scripts to use the new imageruler.
It also adds a github workflow that runs all the scripts, which will help keep things in working order.