Skip to content
This repository has been archived by the owner on Nov 24, 2020. It is now read-only.

corneey.com #333

Closed
NanoMeow opened this issue Nov 17, 2018 · 7 comments
Closed

corneey.com #333

NanoMeow opened this issue Nov 17, 2018 · 7 comments
Labels
f: archived This issue was archived, submit new reports for new problems with this website. f: resolved This issue was resolved. t: other This issue was classified as other issues.

Comments

@NanoMeow
Copy link
Owner

Basic Information

Test link: http://corneey.com/wLknXW
Category: breakage
Reported from: Mexico
Template version: 2

User Environment

Browser: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:63.0) Gecko/20100101 Firefox/63.0
Extension: Nano Defender 15.0.0.72

Additional Message

Nano defender doesnt allow the captcha loading in firefox

@jspenguin2017
Copy link
Collaborator

jspenguin2017 commented Nov 17, 2018

Shortest bypassing is not working anymore.


Captcha is working for me. @LiCybora
image

@jspenguin2017 jspenguin2017 added the f: works This issue could not be reproduced on the maintainer's machine. label Nov 17, 2018
@LiCybora
Copy link

LiCybora commented Nov 19, 2018

Yes, there is issue for Firefox. I am working on it.

image

@LiCybora
Copy link

LiCybora commented Nov 19, 2018

I guess I have quick fix for it, but the fix may affect Chromium and Edge. The problem is Firefox treated webRequest.onBeforeSendHeaders as asynchronous event listeners, while both Chromium and Edge does not support asynchronous event listener (just from MDN notes, I don't have them to test with). I will include the fix in v15.0.0.74 first anyway.

PS: The solution may not be optimal. I just follow the MDN example and change the code to async and problem solved.

Reference:
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/webRequest/onBeforeSendHeaders

Edit: I overlook I make a typo which totally break the solution. Above things are just trash, please ignore.

Edit 2: I recognize the problem now. Seems Firefox throw exception when there is no user-agent (recaptcha attempt to read the user agent string). That's why removing the user-agent break the recaptcha js running.

image

My attempt to fix it is to spoof as other UA instead of removing it (however, the verification page will also gone and directly to target link, but maybe just for this site and untested on other so unsure whether there is side effect.) Any better idea for this?

LiCybora added a commit to LiCybora/NanoDefenderFirefox that referenced this issue Nov 19, 2018
@jspenguin2017
Copy link
Collaborator

jspenguin2017 commented Nov 19, 2018

I thought the chrome namespace only accepts synchronous handlers or asynchronous handlers with callbacks (when available), and the browser namespace is for asynchronous handlers with promises.

Are you sure the timer bypassing is still working after the change? Maybe edit the user agent to Google Bot or something?

@jspenguin2017 jspenguin2017 added t: other This issue was classified as other issues. s: dispatched This issue was dispatched. Awaiting maintainers to respond. s: backlog This issue is on the backlog. and removed f: works This issue could not be reproduced on the maintainer's machine. labels Nov 19, 2018
@jspenguin2017
Copy link
Collaborator

Hum, I might want to try a bot user agent, maybe it goes through the timer and verification altogether.

@LiCybora
Copy link

Yes I tried Google bot and curl UA, both bypass timer and verification, directly forward to target link.
I am not sure whether all sites in the rule will work in the same way

jspenguin2017 added a commit to jspenguin2017/uBlockProtector that referenced this issue Nov 19, 2018
@jspenguin2017 jspenguin2017 added f: resolved This issue was resolved. and removed s: backlog This issue is on the backlog. s: dispatched This issue was dispatched. Awaiting maintainers to respond. labels Nov 19, 2018
@jspenguin2017
Copy link
Collaborator

Fixed.

@github-actions github-actions bot added the f: archived This issue was archived, submit new reports for new problems with this website. label Sep 3, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
f: archived This issue was archived, submit new reports for new problems with this website. f: resolved This issue was resolved. t: other This issue was classified as other issues.
Projects
None yet
Development

No branches or pull requests

3 participants