Added ability to filter incoming requests #45
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added the ability to filter incoming requests, in case some of them doesn't have to be capture in Amazon Xray. This can be useful to reduce noise when using a health check url.
To add a new filter, simply call the
addRequestFilterCallback
function, on theXray
facade, and pass a callback. The current request will be evaluated against this callback. If the callback returns false, the XrayServiceProvider will return before registering the collectors.I've added informations about this new feature in the doc. If you could, kindly, review the doc to make sure I havn't done any grammatical errors, I would highly appreciate it. English is not my primary language.
I've also added tests for the newly added behaviour.
Closes #44
Steps to tests.
register
function, like so: