Skip to content

Commit

Permalink
Merge pull request #1557 from ArchiXL/feedback-form-input-length-fix
Browse files Browse the repository at this point in the history
Implement max length for input fields on the feedback page
osma authored Dec 5, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
2 parents a08b033 + aa8f16d commit 3b9489a
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions controller/WebController.php
Original file line number Diff line number Diff line change
@@ -215,9 +215,9 @@ public function invokeFeedbackForm($request)
if ($request->getQueryParamPOST('message')) {
$feedbackSent = true;
$feedbackMsg = $request->getQueryParamPOST('message');
$feedbackName = $request->getQueryParamPOST('name');
$feedbackEmail = $request->getQueryParamPOST('email');
$msgSubject = $request->getQueryParamPOST('msgsubject');
$feedbackName = substr($request->getQueryParamPOST('name'), 0, 255);
$feedbackEmail = substr($request->getQueryParamPOST('email'), 0, 255);
$msgSubject = substr($request->getQueryParamPOST('msgsubject'), 0, 255);
$feedbackVocab = $request->getQueryParamPOST('vocab');
$feedbackVocabEmail = ($feedbackVocab !== null && $feedbackVocab !== '') ?
$this->model->getVocabulary($feedbackVocab)->getConfig()->getFeedbackRecipient() : null;
6 changes: 3 additions & 3 deletions view/feedback.twig
Original file line number Diff line number Diff line change
@@ -32,15 +32,15 @@
<p>{% trans "feedback_enter_name_email" %}</p>
<p>
<label for="name" class="form-label">{% trans %}Name:{% endtrans %}</label>
<input id="name" class="form-control" type="text" size="40" name="name" placeholder="{% trans %}Enter your name{% endtrans %}">
<input id="name" class="form-control" type="text" size="40" maxlength="255" name="name" placeholder="{% trans %}Enter your name{% endtrans %}">
</p>
<p>
<label for="email" class="form-label">{% trans %}E-mail:{% endtrans %}</label>
<input id="email" class="form-control" type="text" size="40" name="email" placeholder="{% trans %}Enter your e-mail address{% endtrans %}">
<input id="email" class="form-control" type="text" size="40" maxlength="255" name="email" placeholder="{% trans %}Enter your e-mail address{% endtrans %}">
</p>
<p>
<label for="msgsubject" class="form-label">{% trans %}Subject:{% endtrans %} *</label>
<input id="msgsubject" class="form-control" type="text" size="40" name="msgsubject" placeholder="{% trans %}Write a subject{% endtrans %}" >
<input id="msgsubject" class="form-control" type="text" size="40" maxlength="255" name="msgsubject" placeholder="{% trans %}Write a subject{% endtrans %}" >
</p>
<p>
<label for="message" class="form-label">{% trans %}Message:{% endtrans %} *</label>

0 comments on commit 3b9489a

Please sign in to comment.