Skosmos version not showing in Docker install

[ArthurGenet]

What steps will reproduce the problem?

1. Run a Skosmos instance with the latest Docker install
2. Go to "About"

What do you see?

In the Dockerfile, it is written ARG SKOSMOS_VERSION=v.2.9

Is it the version used for the latest Docker install ?

[osma]

Thanks for the report. The Skosmos version is currently extracted from Git version tags, but these are not available when running under Docker. There should be another way of determining the Skosmos version.

[kinow]

Maybe we can include the version when building the image. Can't recall if there's an option to read the version from a static source, but if not it might require some little tweaking in the code.

[ArthurGenet]

Ok thank you for your answers, it is not a big deal, I was just wondering why it wasn't showing.

[osma]

Now the mechanism appears to be broken also without Docker: https://finto.fi/en/about

[osma]

I think we need something like bumpversion for Python projects, i.e. some way of keeping track of the Skosmos version number in a file that's accessible from PHP code.

[kinow]

I wonder if we could use composer.json perhaps? This diff in composer.json:

diff --git a/composer.json b/composer.json
index 1c3eafd8..ab866b5f 100644
--- a/composer.json
+++ b/composer.json
@@ -3,6 +3,7 @@
   "description": "Thesaurus and controlled vocabulary browser using SKOS and SPARQL",
   "type": "project",
   "license": "MIT",
+  "version": "v2.15-dev",
   "repositories": { 
     "lscache": {
       "type": "package",

Followed by composer install, then this change in the PHP code:

diff --git a/model/Model.php b/model/Model.php
index e6f58f3a..e7a08181 100644
--- a/model/Model.php
+++ b/model/Model.php
@@ -76,10 +76,7 @@ class Model
      */
     public function getVersion() : string
     {
-        $ver = null;
-        if (file_exists('.git')) {
-            $ver = rtrim(shell_exec('git describe --tags --always'));
-        }
+        $ver = \Composer\InstalledVersions::getRootPackage()['pretty_version'];
 
         if ($ver === null) {
             return "unknown";

Results in:

I found a few tools/libs¹²³ to bump the composer.json version, or that could be done manually too.

Footnotes

1. https://www.npmjs.com/package/@pxlwidgets/php-composer-version/v/1.1.1 ↩

2. https://github.com/talevskiigor/composer-bump ↩

3. https://github.com/quazardous/php-bump-version ↩

[osma]

Great hints @kinow ! This looks like the correct and best way to do it.

https://www.npmjs.com/package/@pxlwidgets/php-composer-version/v/1.1.1

This tool seems to be Node.js based, maybe not ideal since it requires that developers have a working Node environment which so far hasn't been a requirement for Skosmos development.

https://github.com/talevskiigor/composer-bump

This is from 2016 so may be outdated and unmaintained?

https://github.com/quazardous/php-bump-version

This is also from 2016.

Anyway we can do this manually as well if there's no suitable tool. We can just include it in the Release Process documentation.