Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on notation code in hierarchy loads wrong page #1210

Closed
osma opened this issue Sep 16, 2021 · 0 comments · Fixed by #1211
Closed

Clicking on notation code in hierarchy loads wrong page #1210

osma opened this issue Sep 16, 2021 · 0 comments · Fixed by #1211
Assignees
Milestone

Comments

@osma
Copy link
Member

osma commented Sep 16, 2021

At which URL did you encounter the problem?

http://finto.fi/ykl/en/page/1

What steps will reproduce the problem?

  1. Open any concept in YKL/PLC (or any other vocabulary with notations), e.g. above URL
  2. Click on the notation code of any concept in the hierarchy, e.g. "10" before GENERAL WORKS

What is the expected output? What do you see instead?

Expected that the concept whose notation was clicked would load. Instead the content area shows the front page of the vocabulary!

I think this happens because the notation is contained in a <span class="tree-notation"> element. The JS code expects that the <a> element is clicked, not a subelement like this.

In the current master branch the situation is even worse, since clicking on the label also causes the same problem. This happens because the label was also wrapped in a <span> element in PR #1205 .

What browser did you use? (eg. Firefox, Chrome, Safari, Internet explorer)

Firefox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant