Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the vocabularies.ttl reading functions from Vocabulary into their own class #360

Closed
henriyli opened this issue Nov 27, 2015 · 1 comment
Closed

Refactor the vocabularies.ttl reading functions from Vocabulary into their own class #360

henriyli opened this issue Nov 27, 2015 · 1 comment
Assignees
@henriyli
Labels
enhancement size-medium 2 hours to 2 days
Milestone
1.4

Comments

@henriyli
Copy link
Collaborator

The Vocabulary class contains a lot of functions that read configuration values from the vocabularies.ttl configuration file. These should be refactored into their own class e.g. VocabularyConfig.
@henriyli henriyli added enhancement size-medium 2 hours to 2 days labels Nov 27, 2015
@henriyli henriyli added this to the Next Tasks milestone Nov 27, 2015
henriyli pushed a commit that referenced this issue Nov 27, 2015
first commit for a new class VocabularyConfig , related to #360
3244ebf
henriyli pushed a commit that referenced this issue Nov 27, 2015
fixing tests and refactoring a few more functions, related to #360
3511fab
@osma osma modified the milestones: 1.4, Next Tasks Dec 16, 2015
@osma
Copy link
Member

osma commented Dec 16, 2015

I think this is already done. Moving to 1.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henriyli henriyli

Labels
enhancement size-medium 2 hours to 2 days
Projects
None yet
Milestone
1.4
Development

No branches or pull requests
2 participants
@osma @henriyli