Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback form not sent #378

Closed
tfrancart opened this issue Dec 7, 2015 · 4 comments
Closed

Feedback form not sent #378

tfrancart opened this issue Dec 7, 2015 · 4 comments

Comments

@tfrancart
Copy link
Contributor

(unfortunately URLs cited below are not public)

Problem 1

The base HREF of the fedback form is defined as

<base href="http://thesaurus.web.ined.fr/browser/">

The feedback form is invoked from http://thesaurus.web.ined.fr/browser/[thesaurus]/[language]/feedback

The feedback form submits to "#" :

<form id="feedback-fields" method="post" action="#">

, which submits to http://thesaurus.web.ined.fr/browser/# due to the base HREF declaration. This is not catched by the index.php script, and submitting the form simply redirects to the home page of SKOSMOS, and does not send the feedback e-mail as expected.

Problem 2

Case 1 : When users click on "Feedback" from the homepage (without selecting a vocabulary first), the feedback form is invoked from http://thesaurus.web.ined.fr/browser/[language]/feedback (without the [thesaurus] URL component)
Case 2 : When users first chooses a vocabulary, then clicks on feedback, the feedback form is invoked from http://thesaurus.web.ined.fr/browser/[thesaurus]/[language]/feedback

In Case 1 above, the index.php considers there is only 2 parts in the URL and does not correctly invoker the "invokeFeedbackForm" method.

@osma osma added this to the 1.4 milestone Dec 7, 2015
@osma
Copy link
Member

osma commented Dec 7, 2015

Thank you for reporting! This is indeed a serious problem and affects also our sites finto.fi and dev.finto.fi. The feedback form simply takes to the home page.

@henriyli
Copy link
Collaborator

henriyli commented Dec 7, 2015

I think the above commit fixed problem 1.

@osma
Copy link
Member

osma commented Dec 8, 2015

@tfrancart Still having problems? It's not clear if Problem 2 is actually a separate problem, or just another perspective at the same one.

If all cases work now, this issue could be closed.

@tfrancart
Copy link
Contributor Author

Just tested and it works fine. Problem 2 was actually not a problem (but I couldn't really tell before Problem 1 was fixed).

Thanks very much - again - for your reactivity and the quick fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants