Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor queryConcepts parameters into a class #393

Closed
osma opened this issue Dec 16, 2015 · 1 comment
Closed

Refactor queryConcepts parameters into a class #393

osma opened this issue Dec 16, 2015 · 1 comment
Assignees
@henriyli
Labels
enhancement
Milestone
1.5

Comments

@osma
Copy link
Member

osma commented Dec 16, 2015

The queryConcepts method has acquired a ridiculous number of parameters. We should create a class (ConceptSearchQuery or ConceptSearchParameters) which holds those and then just pass an instance of this class to the queryConcepts method.
@osma osma added this to the Next Tasks milestone Dec 16, 2015
@osma
Copy link
Member Author

osma commented Dec 16, 2015

Perhaps the parameter object should already be given to Model.searchConcepts

@osma osma modified the milestones: 1.5, Next Tasks Dec 18, 2015
henriyli pushed a commit that referenced this issue Jan 5, 2016
refactoring the parameters in the webcontroller search methods, relat…
2a13e32 
…ed to #393
henriyli pushed a commit that referenced this issue Jan 5, 2016
refactoring the rest search method, related to #393
83dcf34
henriyli pushed a commit that referenced this issue Jan 5, 2016
fixing the rest api multiple vocabulary search, related to #393
d66f1b7
henriyli pushed a commit that referenced this issue Jan 5, 2016
fixing the test broken by refactoring, related to #393
16d6e7f
henriyli pushed a commit that referenced this issue Jan 5, 2016
more refactoring related to #393
b18559a
@henriyli henriyli closed this as completed Jan 7, 2016
@osma osma mentioned this issue Jan 18, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@henriyli henriyli

Labels
enhancement
Projects
None yet
Milestone
1.5
Development

No branches or pull requests
2 participants
@osma @henriyli