Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue724 group tab shorten uris #1013

Merged
merged 2 commits into from
Feb 17, 2021
Merged

Conversation

kouralex
Copy link
Contributor

Fixes #724 .

Additionally addresses the following issues:

  1. Adds support for characters -_~ in shortened URIs (see https://en.wikipedia.org/wiki/Percent-encoding#Types_of_URI_characters for more information)
  2. Standardizes behavior between groups and hierarchy tabs (use same code).
  3. Removes a previously unnoticed error that happened to set the parameters in some cases as ?uri=xxx?clang=yy instead of the correct ?uri=xxx&clang=yy way.

@kouralex kouralex added this to the Next Tasks milestone Jun 23, 2020
@kouralex kouralex requested review from joelit and osma June 23, 2020 11:00
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@kouralex
Copy link
Contributor Author

Side note: support for 1) was needed in order to address issues in, for example, AGROVOC, see http://skosmos.dev.finto.fi/agrovoc/fi/page/?uri=http%3A%2F%2Faims.fao.org%2Faos%2Fagrovoc%2Fc_36791

@codecov
Copy link

codecov bot commented Jun 23, 2020

Codecov Report

Merging #1013 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1013   +/-   ##
=========================================
  Coverage     60.29%   60.29%           
  Complexity     1592     1592           
=========================================
  Files            32       32           
  Lines          4425     4425           
=========================================
  Hits           2668     2668           
  Misses         1757     1757           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4bc432...38cbc19. Read the comment docs.

Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested to work. Good job cleaning up the js code!

@joelit joelit merged commit 65bb5ae into master Feb 17, 2021
@miguelvaara miguelvaara modified the milestones: Next Tasks, 2.9 Feb 22, 2021
@osma osma deleted the issue724-group-tab-shorten-uris branch March 11, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Groups tab shows concepts from the same vocab to have URIs like they are from other vocabularies
3 participants