Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #1029 by adding a restriction on deprecated subjects of a concept #1030

Merged
merged 1 commit into from
Feb 17, 2021
Merged

fixes #1029 by adding a restriction on deprecated subjects of a concept #1030

merged 1 commit into from
Feb 17, 2021

Conversation

kouralex
Copy link
Contributor

Fixes #1029

@kouralex kouralex added this to the Next Tasks milestone Jul 10, 2020
@kouralex kouralex requested a review from joelit July 10, 2020 22:10
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jul 10, 2020 •
edited
Loading

Codecov Report

Merging #1030 into master will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1030      +/-   ##
============================================
- Coverage     60.32%   60.31%   -0.02%     
  Complexity     1593     1593              
============================================
  Files            32       32              
  Lines          4429     4430       +1     
============================================
  Hits           2672     2672              
- Misses         1757     1758       +1
Impacted Files Coverage Δ Complexity Δ
model/sparql/GenericSparql.php 67.98% <0.00%> (-0.06%) 318.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37601f9...a2a5d6e. Read the comment docs.

joelit
joelit approved these changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@joelit joelit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine!

@joelit joelit merged commit 8050467 into master Feb 17, 2021
@miguelvaara miguelvaara modified the milestones: Next Tasks, 2.9 Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelit joelit joelit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9
Development

Successfully merging this pull request may close these issues.

Downloading a concept: deprecated subjects of a concept should not be included in end result
3 participants
@kouralex @joelit @miguelvaara