-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue1052 subheadings with text #1055
Conversation
…nt and the side bar
Issue1048 skip to content
Codecov Report
@@ Coverage Diff @@
## master #1055 +/- ##
============================================
+ Coverage 60.31% 60.32% +0.01%
- Complexity 1591 1592 +1
============================================
Files 32 32
Lines 4427 4429 +2
============================================
+ Hits 2670 2672 +2
Misses 1757 1757
Continue to review full report at Codecov.
|
…NatLibFi/Skosmos into issue1052-subheadings-with-text
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whilst this PR gets rid of the table structure found on both ontology page and concept page, I encountered a few issues before this can be merged:
- The content language selection is on the left side now. See attached image below where image on the left hand side has been rendered using the code from this PR branch and the right hand side using the current master.
- As one can see from the above image, this PR creates more space between the separators. Maybe a little bit less would suffice?
- The fonts on the ontology page for some are not alright (font + size, maybe other properties too). See below image.
- I find it a little bit hard to follow the CSS declarations but e.g., setting negative values for the
bottom
property is something I would suggest to avoid as these things should now be easier to adjust with flex properties.
Otherwise, this PR seems to get rid of some tables which is good progress!
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
There was a conflict between bootstrap and the Skosmos css. I resolved it for now, though I suspect more effort should be made ensuring the class names won't conflict in the future.
This was the closest replication of the previous layout. There is an extra pixel row underneath the row separator bar, but it looks good to me.
Fixed.
It's true. The CSS declarations are hard to follow. Restructuring would be in order. |
The new layout to get rid of tables when displaying subheadings. The new heading styles should use this layout as its basis.