Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install composer.phar dependencies #1157

Merged
merged 1 commit into from
May 20, 2021
Merged

Conversation

jrvosse
Copy link
Contributor

@jrvosse jrvosse commented Apr 8, 2021

See issue #1156
Added two lines to download composer.phar and install the dependencies.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 8, 2021

Codecov Report

Merging #1157 (0d83d18) into master (4a050f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1157   +/-   ##
=========================================
  Coverage     67.97%   67.97%           
  Complexity     1584     1584           
=========================================
  Files            32       32           
  Lines          3888     3888           
=========================================
  Hits           2643     2643           
  Misses         1245     1245           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a050f4...0d83d18. Read the comment docs.

Copy link
Collaborator

@kinow kinow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with the following steps:

  • from master, docker-compose up --build (had deleted everything before, including the vendor folder)

image

  • checked out this branch, deleted composer images/containers, then again docker-compose up --build

image

And still no vendor folder in the host, only in the container 👍

image

LGTM

Thanks for reporting it, and for the fix @jrvosse !

@osma
Copy link
Member

osma commented May 20, 2021

I wanted to merge this but add a .dockerignore file in the same go. But since I don't have push access to the PR branch used here, I had to do it via an additional PR - #1162 . Since that PR is based on this PR, merging it will also merge the changes in this PR.

@osma osma merged commit 0d83d18 into NatLibFi:master May 20, 2021
@osma osma added this to the 2.11 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants