Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define order for more vocabulary home page properties #1176

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

osma
Copy link
Member

@osma osma commented Jun 2, 2021

Fixes #1100

This PR defines the order of some properties commonly used for concept scheme metadata:

  • foaf:homepage
  • dc:license
  • dc:rights
  • dc11:rights
  • dc:relation
  • dc11:relation
  • dc:created
  • dc:modified
  • dc:date
  • dc11:date

Thanks to @MikkoAleksanteri for helping to define the order.

Here's a crude screenshot (stitched from two parts...) of the HERO front page after the change:

image

@osma osma added this to the 2.11 milestone Jun 2, 2021
@osma osma self-assigned this Jun 2, 2021
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 2, 2021

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1176 (7224250) into master (be6c64f) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1176   +/-   ##
=========================================
  Coverage     68.05%   68.05%           
  Complexity     1590     1590           
=========================================
  Files            32       32           
  Lines          3904     3904           
=========================================
  Hits           2657     2657           
  Misses         1247     1247           
Impacted Files Coverage Δ
model/Vocabulary.php 87.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be6c64f...7224250. Read the comment docs.

@osma osma merged commit 7b196d5 into master Jun 2, 2021
@osma osma deleted the issue1100-vocab-properties branch June 2, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vocabulary information page properties
1 participant