Faster docker build.

[pulquero]

Moved the config into a layer post "composer install" to speed up build when only changing config.

[kinow]

Looks Ok to me. Only issue is remembering to update image should directory layout changes. I'm not sure which option I prefer, faster build or simpler maintenance.

[pulquero]

Potentially you could have both if nested config and/or the other directories under different parents.Sent from my Galaxy -------- Original message --------From: "Bruno P. Kinoshita" ***@***.***> Date: 06/11/2021 19:28 (GMT+00:00) To: NatLibFi/Skosmos ***@***.***> Cc: pulquero ***@***.***>, Author ***@***.***> Subject: Re: [NatLibFi/Skosmos] Faster docker build. (PR #1235) @kinow commented on this pull request. Looks Ok to me. Only issue is remembering to update image should directory layout changes. I'm not sure which option I prefer, faster build or simpler maintenance. —You are receiving this because you authored the thread.Reply to this email directly, view it on GitHub, or unsubscribe.Triage notifications on the go with GitHub Mobile for iOS or Android.

[kinow]

@pulquero I think I see what you mean. If the source lived in a directory like src, and the config elsewhere, maybe in a config folder, then we could have two distinct layers, building or re-building the image would be much faster, and maintenance of source & docker files would also be quite easy. Let's wait and see what others think too 👍

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[pulquero]

Here, found a way to get the php packages into their own layer.

[kinow]

This looks like a great fix @pulquero ! Not approving because I didn't have time to try it out locally, but in principle looks like a great improvement, with little to no difference in maintenance for devs 👏

[miguelvaara]

The the building phase was clearly faster after changing the configuration. Nice work!

Thanks @pulquero for the PR and thanks @kinow for your commenting.