Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP 8 from build matrix to avoid hanging CI jobs #1249

Merged
merged 1 commit into from
Nov 12, 2021

Conversation

osma
Copy link
Member

@osma osma commented Nov 12, 2021

Reasons for creating this PR

GitHub Actions CI build jobs are getting stuck on PHP 8. This causes unnecessary CI resource usage and delays the completion of build jobs by 6 hours.

Link to relevant issue(s), if any

Description of the changes in this PR

Remove PHP8 from php_versions in the CI build matrix.

Known problems or uncertainties in this PR

It would be better to get tests to pass on PHP8, but that would take more effort, so as a stopgap measure I'm just disabling them for now.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

This is a CI configuration change, no need for new tests.

@osma osma added this to the 2.13 milestone Nov 12, 2021
@osma osma self-assigned this Nov 12, 2021
@codecov
Copy link

codecov bot commented Nov 12, 2021

Codecov Report

Merging #1249 (3721423) into master (4f33798) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1249   +/-   ##
=========================================
  Coverage     69.26%   69.26%           
  Complexity     1646     1646           
=========================================
  Files            32       32           
  Lines          4041     4041           
=========================================
  Hits           2799     2799           
  Misses         1242     1242           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f33798...3721423. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@osma osma merged commit a770d4c into master Nov 12, 2021
@osma osma deleted the issue1243-disable-php8-ci-jobs branch November 12, 2021 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant