Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary encoding of slashes in URIs in RestControllerTest #1283

Merged
merged 1 commit into from
Mar 2, 2022

Conversation

osma
Copy link
Member

@osma osma commented Mar 2, 2022

Reasons for creating this PR

In #1282, I reformatted JSON strings. But the JSON reformatting tool I used also escapes regular slashes, which appear a lot in URIs. I didn't notice that before merging 😔 So I'm removing the unnecessary escapes in this PR.

Link to relevant issue(s), if any

Description of the changes in this PR

Remove unnecessary backslashes in JSON strings within RestControllerTest

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 2.14 milestone Mar 2, 2022
@osma osma self-assigned this Mar 2, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 2, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Mar 2, 2022

Codecov Report

Merging #1283 (7040175) into master (9dc7ea9) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1283   +/-   ##
=========================================
  Coverage     69.36%   69.36%           
  Complexity     1649     1649           
=========================================
  Files            32       32           
  Lines          4047     4047           
=========================================
  Hits           2807     2807           
  Misses         1240     1240           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dc7ea9...7040175. Read the comment docs.

@osma osma merged commit 2896c69 into master Mar 2, 2022
@osma osma deleted the fix-reformat-restcontrollertest-json-part2 branch March 2, 2022 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

1 participant