Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop unused URI.js dependency #1300

Merged
merged 1 commit into from
Apr 8, 2022
Merged

drop unused URI.js dependency #1300

merged 1 commit into from
Apr 8, 2022

Conversation

osma
Copy link
Member

@osma osma commented Apr 8, 2022

Reasons for creating this PR

As noted in #1297, the URI.js dependency is unnecessary. In addition the version Skosmos depends on is outdated and has multiple security issues.

Link to relevant issue(s), if any

Description of the changes in this PR

Drop the dependency to URI.js

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works (if not, explain why below)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

(JS dependencies don't affect tests)

@osma osma added the bug label Apr 8, 2022
@osma osma added this to the 2.15 milestone Apr 8, 2022
@osma osma self-assigned this Apr 8, 2022
@osma osma changed the title drop unused URI.js dependency. Fixes #1297 drop unused URI.js dependency Apr 8, 2022
@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 8, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #1300 (1bfa01b) into master (31f430b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1300   +/-   ##
=========================================
  Coverage     69.44%   69.44%           
  Complexity     1657     1657           
=========================================
  Files            32       32           
  Lines          4068     4068           
=========================================
  Hits           2825     2825           
  Misses         1243     1243           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31f430b...1bfa01b. Read the comment docs.

@osma osma merged commit df06b59 into master Apr 8, 2022
@osma
Copy link
Member Author

osma commented Apr 8, 2022

Backported to v2.14-maintenance branch in commit 2c55eef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

URI.js dependency security update
1 participant