Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show deprecated concepts without replacement in change list (skosmos 3) #1534

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

osma
Copy link
Member

@osma osma commented Sep 28, 2023

Reasons for creating this PR

PR #1529 fixed issue #1513 for skosmos 2 - the problem of deprecated concepts without an isReplacedBy relationship not being shown in the change list. This PR performs the same fixes for Skosmos 3.

Link to relevant issue(s), if any

Description of the changes in this PR

See #1529

Known problems or uncertainties in this PR

Doesn't contain the front-end parts of the fix.

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma requested a review from joelit September 28, 2023 13:46
@osma osma self-assigned this Sep 28, 2023
@osma osma added the bug label Sep 28, 2023
@osma osma added this to the 3.0 milestone Sep 28, 2023
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (e00c2b6) 70.51% compared to head (bfa37a8) 70.51%.
Report is 16 commits behind head on skosmos-3.

Additional details and impacted files
@@             Coverage Diff              @@
##             skosmos-3    #1534   +/-   ##
============================================
  Coverage        70.51%   70.51%           
- Complexity        1642     1643    +1     
============================================
  Files               32       32           
  Lines             4314     4314           
============================================
  Hits              3042     3042           
  Misses            1272     1272           
Files Coverage Δ
src/model/sparql/GenericSparql.php 92.54% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osma osma merged commit cbd43e4 into skosmos-3 Nov 14, 2023
@osma osma deleted the issue1513-deprecated-changes-fix-skosmos-3 branch November 14, 2023 08:58
@osma osma modified the milestones: 3.x, 3.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

1 participant