-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Concept page template and Cypress tests #1549
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## skosmos-3 #1549 +/- ##
===============================================
+ Coverage 70.51% 70.53% +0.01%
Complexity 1643 1643
===============================================
Files 32 32
Lines 4314 4313 -1
===============================================
Hits 3042 3042
+ Misses 1272 1271 -1 ☔ View full report in Codecov by Sentry. |
64d0f24
to
4293474
Compare
… to loop over an array
09ef9cf
to
ed7db46
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 🥇
I see that there's a little regression on the vocabulary home page, for example some background colors have changed. This is most likely due to shared CSS rules. I will try to fix that before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple of suggestions for this PR. I also wrote further requirements for concept pages in the comments for the associated issue #1484 that would be out of scope for this PR.
his is a solid start! Thanks especially for dismantling some of the old Skosmos 2.x template logic that is no longer in use. The cypress tests are also a sight worth seeing. Two michelin stars!
… multiple boxes in main-content area
Still TODO:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hmm, something broke in the Cypress tests, need to fix that as well before merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be problems with two cypress tests that should be fixed
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Reasons for creating this PR
Reimplement the concept page template so it follows the new Skosmos 3 design.
Also add Cypress tests verifying the existing functionality.
This implements just the basic functionality. Many features and special cases are not implemented yet; see checklist in #1484 (comment)
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
n/a
Checklist
.sr-only
class, color contrast)