-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add logos for Skosmos 3 #1562
Add logos for Skosmos 3 #1562
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## skosmos-3 #1562 +/- ##
============================================
Coverage 70.54% 70.54%
Complexity 1644 1644
============================================
Files 32 32
Lines 4315 4315
============================================
Hits 3044 3044
Misses 1271 1271 ☔ View full report in Codecov by Sentry. |
{% if request.vocabid == '' and request.page != 'about' and request.page != 'feedback' %} | ||
<span class="fs-6 py-3 text-light">Yhteishaku sanastoista v</span> | ||
{% else %} | ||
<a id="skosmos-logo-top" href="{{ request.lang }}/{% if request.contentLang and request.contentLang != request.lang %}?clang={{ request.contentLang }}{% endif %}{% if request.queryParam('anylang') == 'on' %}{% if request.contentLang == request.lang %}?{% else %}&{% endif %}anylang=on{% endif %}"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a terrible way of generating the link URL for the home page, but I see that it has been used in many other places as well (a few lines down in the same file) so I guess one more time doesn't hurt much.
However, I think a better mechanism should be developed. We already have the custom link_url
filter, maybe it could be used instead, with some enhancements?
Looks good and gets the job done. I commented about the URL generation, but that is a more general problem, not specific to this PR. I'll merge this as it is. |
Reasons for creating this PR
Skosmos 3 is missing logos from all pages, this PR adds a logo to headerbar on landing page and to topbar on other pages.
Link to relevant issue(s), if any
Description of the changes in this PR
Known problems or uncertainties in this PR
Headerbar (and thus logo) is visible on about and feedback pages, which should be fixed.
Checklist
.sr-only
class, color contrast)