Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Concept page features: scopeNotes with HTML, hide subprops of hiddenLabel, timestamps #1583

Merged
merged 4 commits into from
Jan 25, 2024

Conversation

osma
Copy link
Member

@osma osma commented Jan 24, 2024

Reasons for creating this PR

Adding more features to the concept page:

  • scopeNotes with HTML links
  • don't show subproperties of skos:hiddenLabel
  • show created & modified timestamps

Link to relevant issue(s), if any

Description of the changes in this PR

  • changes to the concept page template & CSS to implement above mentioned features
  • new Cypress tests to verify them

Known problems or uncertainties in this PR

n/a

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Jan 24, 2024
@osma osma self-assigned this Jan 24, 2024
Copy link

sonarqubecloud bot commented Jan 24, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e049d3) 70.54% compared to head (8d34f57) 70.54%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1583   +/-   ##
=========================================
  Coverage     70.54%   70.54%           
  Complexity     1644     1644           
=========================================
  Files            32       32           
  Lines          4315     4315           
=========================================
  Hits           3044     3044           
  Misses         1271     1271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miguelvaara miguelvaara self-requested a review January 25, 2024 09:39
Copy link
Contributor

@miguelvaara miguelvaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I reviewed the code changes and everything looked tidy and correct
  • I took a general overview of the concept page with the changes in mind and everything looked good
  • I compared the changes to the layout guide and the result is sufficiently close to the agreed design
  • The Cypress test code looked good
  • Cypress tests passed
  • I checked the recent changes against the agreed PR definition:
    • Implements part of the requirements defined in the issue without going beyond its scope
    • PR template used

Good job, I think it can be merged!

@osma osma merged commit d0aa524 into main Jan 25, 2024
12 checks passed
@osma osma deleted the issue1484-concept-page-features branch January 25, 2024 11:05
@osma osma modified the milestones: 3.x, 3.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants