Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breadcrumbs on concept page #1586

Merged
merged 9 commits into from
Jan 31, 2024
Merged

Breadcrumbs on concept page #1586

merged 9 commits into from
Jan 31, 2024

Conversation

osma
Copy link
Member

@osma osma commented Jan 30, 2024

Reasons for creating this PR

Implement the breadcrumb display on the concept page.

With long paths, the top levels are initially hidden. Clicking on the first ... will display the hidden paths. This is implemented using the Collapse functionality in Bootstrap.

Link to relevant issue(s), if any

Description of the changes in this PR

  • add a section to the concept page template that displays breadcrumbs
  • add corresponding CSS styles
  • add translations for the string "Breadcrumbs", used as the aria-label value for the breadcrumb navigation element
  • rename some variables passed from WebController to the twig templates to give them more descriptive names

Known problems or uncertainties in this PR

  • needs Cypress tests
  • verify accessibility

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@osma osma added this to the 3.0 milestone Jan 30, 2024
@osma osma self-assigned this Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d0aa524) 70.54% compared to head (59104e2) 70.54%.
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #1586   +/-   ##
=========================================
  Coverage     70.54%   70.54%           
  Complexity     1644     1644           
=========================================
  Files            32       32           
  Lines          4315     4315           
=========================================
  Hits           3044     3044           
  Misses         1271     1271           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@osma osma changed the title initial rough implementation of breadcrumbs on concept page WIP: breadcrumbs on concept page Jan 30, 2024
@osma osma marked this pull request as ready for review January 30, 2024 14:39
@osma osma changed the title WIP: breadcrumbs on concept page Breadcrumbs on concept page Jan 30, 2024
@osma osma requested a review from joelit January 30, 2024 14:40
@miguelvaara miguelvaara self-requested a review January 31, 2024 11:19
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

2 New issues
0 Security Hotspots
No data about Coverage
0.7% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@miguelvaara miguelvaara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the review:

  • General overview -> looks good!
  • Tested the behavior of breadcrumbs on long paths -> looks good!
  • Tested functionality - it works!
  • Compared against the agreed Definition of Ready for PRs -> nearly meets the requirements (In the PR exceptions were mentioned)
  • Exceeds the exceptions mentioned in the PR as it includes comprehensive Cypress tests with excellent comments.
  • Compared against the agreed layout guide and currently aligns well with it (styles will be refined later) and is already quite close to the final goal.

Well done!

@osma osma merged commit e6a98e4 into main Jan 31, 2024
12 checks passed
@osma osma deleted the issue1484-concept-page-breadcrumbs branch January 31, 2024 12:28
@osma osma modified the milestones: 3.x, 3.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants