Sort concepts in hierarchical view by label and locale #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osma
requested changes
Apr 24, 2024
| @@ -61,7 +61,7 @@ describe('Vocabulary home page', () => { | |||
| cy.get('#tab-alphabetical').contains('a', 'care institutions').click() | |||
|
|
|||
| // check the concept prefLabel | |||
| cy.get('#concept-heading h1').invoke('text').should('equal', 'care institutions') | |||
| cy.get('#concept-heading h1', {'timeout': 15000}).invoke('text').should('equal', 'care institutions') | |||
There was a problem hiding this comment.
It was failing before without the timeout but now it isn't anymore. I'll take it out
osma
approved these changes
Apr 24, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for creating this PR
Concepts in hierarchical view are not currently sorted. This PR add functionality to sort concepts by their label according to locale.
Link to relevant issue(s), if any
Description of the changes in this PR
Sort concepts in hierarchy by label and locale when they are added to hierarchy tree
Addresses requirement 9 in #1521
Known problems or uncertainties in this PR
Concepts are only sorted by label and locale, not notation codes or notation sorting style
Checklist
.sr-onlyclass, color contrast)