Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchical view style fixes #1638

Merged
merged 6 commits into from
Aug 7, 2024
Merged

Hierarchical view style fixes #1638

merged 6 commits into from
Aug 7, 2024

Conversation

UnniKohonen
Copy link
Contributor

Reasons for creating this PR

Hierarchical view has several minor style errors, this PR fixes them.

Link to relevant issue(s), if any

Description of the changes in this PR

  • Fix width of concepts
  • Remove unnecessary borders
  • Set last class correctly
  • Use images instead of unicode characters in buttons

Addresses 3g, 3h and 3c in #1521

Known problems or uncertainties in this PR

Checklist

  • phpUnit tests pass locally with my changes
  • I have added tests that show that the new code works, or tests are not relevant for this PR (e.g. only HTML/CSS changes)
  • The PR doesn't reduce accessibility of the front-end code (e.g. tab focus, scaling to different resolutions, use of .sr-only class, color contrast)
  • The PR doesn't introduce unintended code changes (e.g. empty lines or useless reindentation)

@UnniKohonen UnniKohonen added this to the 3.0 milestone Jul 23, 2024
@UnniKohonen UnniKohonen self-assigned this Jul 23, 2024
Copy link
Member

@osma osma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this briefly and the changes look very good! But there are currently two problems:

  1. There is a conflict that needs to be resolved
  2. The Cypress Axe test for the concept page fails for some reason

If you can fix these, then this can be merged!

Copy link

sonarqubecloud bot commented Aug 7, 2024

@UnniKohonen UnniKohonen merged commit cc655b2 into main Aug 7, 2024
10 checks passed
@UnniKohonen UnniKohonen deleted the hierarchy-style-fixes branch August 7, 2024 13:38
@osma osma modified the milestones: 3.x, 3.0 Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done (verified in test.dev.finto.fi, set Milestone 3.0 for both issue & PR)
Development

Successfully merging this pull request may close these issues.

2 participants