-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Order hierarchy by notation #1651
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work very well on the example vocabularies I tested (YKL, YSO-aika, okm-tieteenala). However, we don't really have a recent use case for numeric sorting of notations (the PTVL classification that required this was removed from Finto some time ago) so I couldn't test that with a real example. Anyway, I suppose it's good enough given that we don't even need it at the moment :)
I'd like to see Cypress tests that verify that the order in the hierarchy follows the notations, could you add some? I know that we're currently lacking Cypress tests for a lot of sidebar functionality, so adding tests could also be done as a separate effort if you prefer.
I made a suggestion to rename the compareStrs function to compareConcepts.
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Reasons for creating this PR
Hierarchy is currently only ordered by labels. It should be possible to order it by notation codes as well
Link to relevant issue(s), if any
Description of the changes in this PR
Sort concepts based on notation codes using both lexical and natural sorting.
Addresses requirement 6d in #1521
Known problems or uncertainties in this PR
Checklist
.sr-only
class, color contrast)